BUG: .isin(...) now coerces sets to lists #13014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests! |
|
I swear |
|
How to kill an underway Travis job? |
jreback
added
Bug
Indexing
| @@ -113,6 +113,8 @@ def isin(comps, values): | |||
| raise TypeError("only list-like objects are allowed to be passed" | |||
| " to isin(), you passed a " | |||
| "[{0}]".format(type(values).__name__)) | |||
| if com.is_set_like(values): | |||
There was a problem hiding this comment.
instead of doing this, I think you can:
if not isinstance(values, np.ndarray):
values = list(values)
Then don't even need the next check
Current coverage is 83.91%@@ master #13014 diff @@
==========================================
Files 136 136
Lines 49908 49920 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 41876 41888 +12
Misses 8032 8032
Partials 0 0
|
|
@ch41rmn gr8. can you add a whatsnew note in bug fixes. ping when pushed. |
|
looks good. can you add a whatsnew note. ping when pushed. |
|
thanks @ch41rmn I merged this. hoping to get the release out shortly. |
|
Thanks for merging @jreback. Apologies I didn't get to adding the whatsnew note in time, have been away for the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffcomp.isin(values)now coercesvaluesfrom a set into a list. This was failing whencompis a datetime dtype andvaluesis a set, where.isinwill try to runto_datetime(values)on the unordered set and fail.