-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
COMPAT: some compatibility fixes with new numpies #13010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dtype=np.uint16), | ||
'u32': Series(np.random.random_integers(0, high=2**30, size=5), | ||
'u32': Series(np.random.randint(0, high=2**30, size=5), | ||
dtype=np.uint32), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this a problem, but these function calls aren't quite equivalent (closed vs. open interval for random_integers
and randint
respectively).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they seem the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a moot point if Travis is still happy, but for reference, they are not equivalent by definition.
@tacaswell @mdboom, using mpl 1.5.0 here. I was turning on deprecation warnings. (we get a bunch of these in test suite), known issue?
|
Thanks for pointing out. Not a known issue (to me at least). I'll see if I can reproduce locally. |
@mdboom this is using pretty recently released |
There is a pr fixing this, but I am failing to find it. |
Thanks @tacaswell. Unfortunately, it doesn't look there's much of a way to workaround that from the outside... |
the fix will be it 1.5.2 / 2.0, which ever comes first |
thanks @mdboom @tacaswell no worries. just trying to have clean test outputs. |
No description provided.