Skip to content

BUG: Fix argument order in call to super #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eddiejessup
Copy link
Contributor

@eddiejessup eddiejessup commented Apr 19, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

super should have arguments (type, object), not (object, type).

I've run test_fast.sh using Python 2.7 and it gives 2 failures relating to language locales (I'm using en_GB). Pretty sure these are unrelated to the commit.

@jreback
Copy link
Contributor

jreback commented Apr 19, 2016

hah I guess we don't have a test for that

can u create a test that hits that path as well

@eddiejessup
Copy link
Contributor Author

Sure. I could find a concrete sub-class of PandasObject that doesn't implement memory_usage, instantiate that, get its sizeof() and check it returns something of the correct type? For example, from a quick look, looks like the GroupBy class is such a class.

@jreback jreback added Bug Compat pandas objects compatability with Numpy or Python functions labels Apr 19, 2016
@jreback
Copy link
Contributor

jreback commented May 7, 2016

can you rebase / update

@codecov-io
Copy link

codecov-io commented May 19, 2016

Current coverage is 83.76%

Merging #12924 into master will decrease coverage by 0.38%

@@             master   #12924   diff @@
========================================
  Files           138      135     -3   
  Lines         50392    49640   -752   
  Methods           0        0          
  Branches          0        0          
========================================
- Hits          42406    41583   -823   
- Misses         7986     8057    +71   
  Partials          0        0          

Powered by Codecov. Last updated by 4b50149...68e4b90

super should be passed (type, object), not (object, type).
@eddiejessup
Copy link
Contributor Author

@jreback Added a test to hit the path.

@jreback jreback closed this in 070e877 May 19, 2016
@jreback
Copy link
Contributor

jreback commented May 19, 2016

thanks! nice way of testing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants