-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix argument order in call to super #12924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hah I guess we don't have a test for that can u create a test that hits that path as well |
Sure. I could find a concrete sub-class of |
can you rebase / update |
Current coverage is 83.76%@@ master #12924 diff @@
========================================
Files 138 135 -3
Lines 50392 49640 -752
Methods 0 0
Branches 0 0
========================================
- Hits 42406 41583 -823
- Misses 7986 8057 +71
Partials 0 0
|
super should be passed (type, object), not (object, type).
@jreback Added a test to hit the path. |
thanks! nice way of testing this! |
git diff upstream/master | flake8 --diff
super
should have arguments (type, object), not (object, type).I've run
test_fast.sh
using Python 2.7 and it gives 2 failures relating to language locales (I'm using en_GB). Pretty sure these are unrelated to the commit.