_get_new_index always returns index in PeriodIndexResampler #12875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
changed the title
max-sixty
force-pushed
the
get-new-index-returns-index
branch
from
daba5ab to
1f85913
Compare
|
was this meant to be a PR? |
|
Yes! Split this out of the other given it wasn't directly impacting the issue. |
|
can you add some tests for validation, or you can just roll this into the other issue |
|
OK I will roll in. I know you at times prefer things split out where it doesn't directly impact; easier for me to roll it in though |
|
Rolling into #12874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffCleans up a method that returned different types depending on the length of the index