COMPAT: .query/.eval should work w/o numexpr being installed if possible #12864
Conversation
jreback
added
the
Compat
jreback
force-pushed
the
numexpr_compat
branch
3 times, most recently
from
2aaf6a8 to
5a67bd4
Compare
| @@ -131,6 +131,7 @@ API changes | |||
|
|
|||
|
|
|||
|
|
|||
| - the default for ``.query()/.eval()`` is now ``engine=None`` which will use ``numexpr`` if its installed, else will fallback to the ``python`` engine. This mimics the pre-0.18.1 behavior if ``numexpr`` is installed (and which previously would raise if ``numexpr`` was NOT installed and ``.query()/.eval()`` was used). (:issue:`12749`) | |||
There was a problem hiding this comment.
@jorisvandenbossche @TomAugspurger wording make sense? This is really a bug fix, but wanted to highlite it.
There was a problem hiding this comment.
"its" -> "it's". Maybe change "and which would previously..." to "Previously, if numexpr was not installed, .query()/.eval() would raise."
Does it raise a PerformanceWarning when it falls back to python? Might be good to mention that here.
There was a problem hiding this comment.
no reason to show a PerformanceWarning. I guess we could, but the issue addressed here is thatt was raising an ImportError if you didn't have numexpr installed and DIDN't specify ``engine='python'` which was not the default
There was a problem hiding this comment.
The issue of showing a PerformanceWarning (good idea) is that we have to be careful when doing it, because for example string ops are by definition in python, so will create a separate issue for that.
There was a problem hiding this comment.
Sounds good. +1 to this change.
closes #12749