TST: Add numeric coercion tests #12841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Testing
| @@ -1820,3 +1820,350 @@ def test_multilevel_preserve_name(self): | |||
| result2 = s.ix['foo'] | |||
| self.assertEqual(result.name, s.name) | |||
| self.assertEqual(result2.name, s.name) | |||
|
|
|||
There was a problem hiding this comment.
why don't we put these in tests/indexing/test_coercion.py?
sinhrks
force-pushed
the
dtype_tests
branch
3 times, most recently
from
a028ef1 to
8b1576c
Compare
|
@jreback OK, created |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffBecause dtype coercion affects to lots of functions, would like to fix in the following steps. The behavior which looks incorrect are commented with
TODO_GH127471(this PR) Add numeric related tests to clarify the current behaviour (and future change)
2. Fix numeric coercion.
3. Add datetime-like tests.
4. Fix datetime-like coercion.