BUG: DataFrame.drop() does nothing for non-unique Datetime MultiIndex #12783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #12701 Follows the suggested fix in the comments to the bug report. Also added a line in whatsnew and a test.
jreback
added
Bug
Indexing
|
@jonaslb nothing fails on master main build. There is a single failure on 2 of the compat builds, but these are known. are you talking about something specific? |
|
@jreback Here's a gist (7 errors / 2 failures) of my test-run. Yes I guess it's specific since it's something with clipboard and then there are some index and slice problems apparently. But lets wait and see what travis says - I'm pretty certain I didn't mess it up with this commit :) Sometime later I'll look more into it and maybe make bug reports. |
|
thanks @jonaslb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffCloses #12701
Follows the suggested fix in the comments to the bug report.
Also added a line in whatsnew and a test.
Regarding the tests it passes the one I added. But I just noticed that plenty others fail and I have yet to find out whether it's caused by this (who knows, it might)
Update: It's the same tests failing on master branch as on this one (phew..). I guess the errors deserve bug reports but that's for another time.