BUG: fixed SAS7BDATReader._get_properties #12658
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self._path_or_buf.read is an obvious mistake also added + total_align to _os_name_offset and _os_make_offset as they are present in the original code from Jared Hobbs: https://bitbucket.org/jaredhobbs/sas7bdat/src/da1faa90d0b15c2c97a2a8eb86c91c58081bdd86/sas7bdat.py?fileviewer=file-view-default#sas7bdat.py-1450
Closed
|
can you add a test that hits this path |
|
Do you want me to include that test file in this PR even if the file is not readable even with this PR (due to #12659)? |
|
prob easiest to have a single PR with the test files. |
|
btw, this fixes issue #12647 |
|
I've uploaded a test file here: https://github.com/raderaj/pandas_SAS_snippets/blob/master/productsales.sas7bdat |
|
closed by #12656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a crasher I had in one of my files using SAS7BDATReader.
cc: @kshedden
self._path_or_buf.read is an obvious mistake
also added + total_align to _os_name_offset and _os_make_offset as they are
present in the original code from Jared Hobbs:
https://bitbucket.org/jaredhobbs/sas7bdat/src/da1faa90d0b15c2c97a2a8eb86c91c58081bdd86/sas7bdat.py?fileviewer=file-view-default#sas7bdat.py-1450