Skip to content

BUG: pivot_table dropna=False drops columns/index names #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: pivot_table dropna=False drops columns/index names #12650

wants to merge 1 commit into from

Conversation

OXPHOS
Copy link
Contributor

@OXPHOS OXPHOS commented Mar 17, 2016

Bug fixed from pull request #12327.

jreback
jreback reviewed Mar 17, 2016
View reviewed changes
pandas/tools/tests/test_pivot.py
c = np.array(['dull', 'dull', 'dull', 'dull',
'dull', 'shiny', 'shiny'], dtype=object)

res = crosstab(a, [b, c], rownames=['a'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd.crosstab (and same below)

@jreback jreback added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode MultiIndex labels Mar 17, 2016
@jreback jreback added this to the 0.18.1 milestone Mar 17, 2016
@OXPHOS
Copy link
Contributor Author

OXPHOS commented Mar 17, 2016

@jreback Thanks for the comments. But I don't think this is the correct way to cherry pick commits..?? I'll learn some github basics and fix this thing within next two days.

@jreback
Copy link
Contributor

jreback commented Mar 17, 2016

@OXPHOS it looks ok. you prob want to squash commits down though to make it easier to work with (e.g. squash yours to a single one, his the same).

@OXPHOS
Copy link
Contributor Author

OXPHOS commented Mar 17, 2016

Cool. Got it. Thanks!

On Thu, Mar 17, 2016 at 12:19 PM, Jeff Reback [email protected]
wrote:

@OXPHOS https://github.com/OXPHOS it looks ok. you prob want to squash
commits down though to make it easier to work with (e.g. squash yours to a
single one, his the same).

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#12650 (comment)

@OXPHOS OXPHOS force-pushed the master branch 2 times, most recently from acc85fc to 3acf970 Compare April 12, 2016 19:04
@OXPHOS
Copy link
Contributor Author

OXPHOS commented Apr 13, 2016

@jreback ready to merge : )

@jreback jreback mentioned this pull request Apr 14, 2016
Closed
jreback
jreback reviewed Apr 14, 2016
View reviewed changes
pandas/tools/tests/test_pivot.py
@@ -965,6 +965,62 @@ def test_margin_ignore_dropna_bug(self):
expected.columns = Index([3, 4, 'All'], name='b')
tm.assert_frame_equal(actual, expected)

# GH 12642
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this to the whatsnew (as a separate bug fix line)

@jreback jreback closed this in 3bed097 Apr 17, 2016
@jreback
Copy link
Contributor

jreback commented Apr 17, 2016

thanks @OXPHOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.

BUG: crosstab with margins=True and dropna=False crosstab dropna=False breaks columns.names
2 participants
@OXPHOS @jreback