Allow dtype='category' or dtype=None for Series with Categorical #12636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,6 +80,13 @@ def test_basic(self): | |||
| self.assertFalse(is_categorical(np.dtype('float64'))) | |||
| self.assertFalse(is_categorical(1.0)) | |||
|
|
|||
| def test_series_with_dtype(self): | |||
| self.assertRaises( | |||
There was a problem hiding this comment.
Can you add a comment like #GH 12574, pointing back to the original issue?
|
Just the one comment, +1 otherwise (assuming Travis passes). Thanks! |
| @@ -195,9 +196,12 @@ def __init__(self, data=None, index=None, dtype=None, name=None, | |||
| else: | |||
| data = data.reindex(index, copy=copy) | |||
| elif isinstance(data, Categorical): | |||
| if dtype is not None: | |||
| # Allow dtype=category only, otherwise error | |||
| if ((dtype is not None) and | |||
There was a problem hiding this comment.
this is not right here; use is_categorical_dtype(dtype)
Current coverage is
|
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to pass dtype='category' when creating a Series with Categorical, but produces a ValueError is any non-categorical dtype is passed.
git diff upstream/master | flake8 --diff