BUG: .rename* not treating Series as mapping #12626
Conversation
|
I might remove or rename |
|
@TomAugspurger btw, make sure you are rebased on current master. |
| (not com.is_sequence(index) and not callable(index)) or | ||
| (com.is_list_like(index) and not isinstance(index, MutableMapping)) | ||
| ) | ||
| if is_scalar_or_list: |
There was a problem hiding this comment.
yeah I think lib.isscalar(...) or com.is_list_like(...) is more clear
There was a problem hiding this comment.
com.is_list_like(dict) is True, and I need to treat dicts differently than lists.
But if we're going to be raising on Series.rename(list) anway, I won't have to worry about lists at all...
| @@ -55,6 +55,13 @@ def test_rename(self): | |||
| renamed = renamer.rename({}) | |||
| self.assertEqual(renamed.index.name, renamer.index.name) | |||
|
|
|||
| def test_rename_by_series(self): | |||
| s = Series(range(5), name='foo') | |||
| renamer = Series({1: 10, 2: 20}) | |||
There was a problem hiding this comment.
maybe tests both dict and Series (for the renamer), and anything else that could be there (e.g. callable)? you prob already have these tests......
d = {1: 10, 2: 20}
for value in [ d, Series(d) ]:
....
for
There was a problem hiding this comment.
These should all covered by test_generic now. Initially I didn't understand how test_generic was setup, so I added the test here. I think these tests are all redundant, and could remove them this one and test_rename above, but I always worry about deleting tests :)
There was a problem hiding this comment.
cool np. yeah. hard to stop the propogation of tests :)
Closes pandas-dev#12623 I added com.is_dict_like in pandas-dev#11980 and failed to use it for the `rename` method. Using that now and did some refactoring while I was in there. Added more tests for rename.
TomAugspurger
force-pushed
the
rename-series
branch
from
51a36af to
10ea582
Compare
|
Ok, the tests for the different possible arguments are here. I simplified the stuff with |
|
thanks @TomAugspurger |
Closes #12623
I added com.is_dict_like in #11980
and failed to use it for the
renamemethod. Using that now and didsome refactoring while I was in there. Added more tests for rename.