Resolve ImportError in read_gbq which appears with oauthclient >= 2.0 #12582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why are you requiring a newer version? can the older versions work as well as? much prefer not to break anything and just work with the version you have |
|
further we really need s way to test this automatically on Travis with different configurations |
|
|
|
0.18.0 is real easing shortly but it doesn't matter - you need to adapt to the installed configuration whatever it is use try excepts |
Valid BigQuery credentials are required to test the gbq module on travis. How should we go about that? Can we continue the discussion in #11089? |
parthea
changed the title
read_gbq which appears with oauthclient >= 2.0 #12572read_gbq which appears with oauthclient >= 2.0
parthea
force-pushed
the
fix_read_gbq_failure
branch
2 times, most recently
from
24c133a to
a08bb1e
Compare
|
I've pushed a new version that is more flexible. All tests passed locally with oauthclient 2.0.1: All tests passed locally with oauthclient 1.5.0: |
|
can you confirm this also works with older versions of this lib? (I can shove this in 0.18.0 so doesn't really matter), but just to be on safe side. Also pls update |
jreback
added
Google I/O
Compat
| @@ -43,3 +43,5 @@ Performance Improvements | |||
|
|
|||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
jreback
changed the title
read_gbq which appears with oauthclient >= 2.0
|
@parthea lmk as soon as you can update. ty. |
parthea
force-pushed
the
fix_read_gbq_failure
branch
from
a08bb1e to
8b488e1
Compare
| * Google's `python-gflags <http://code.google.com/p/python-gflags/>`__ | ||
| and `google-api-python-client <http://github.com/google/google-api-python-client>`__: Needed for :mod:`~pandas.io.gbq` | ||
| * `httplib2 <http://pypi.python.org/pypi/httplib2>`__: Needed for :mod:`~pandas.io.gbq` | ||
| * Google's `python-gflags <http://code.google.com/p/python-gflags/>`__ , |
There was a problem hiding this comment.
can u add in oauth2client into the appropriate ci/requirements files (eg where the existing reward are)
parthea
force-pushed
the
fix_read_gbq_failure
branch
from
8b488e1 to
81374af
Compare
| @@ -2,5 +2,6 @@ blosc | |||
| httplib2 | |||
| google-api-python-client == 1.2 | |||
| python-gflags == 2.0 | |||
| oauth2client == 1.5.0 | |||
|
ok, assuming travis passes, pls you certify tests passing on your local (with both oauth versions). create 2 different conda envs locally (if you don't have already), then this is easy. maybe do one in py3 and the other in py2. |
|
ok, this looks good. lmk when you have run tests locally. |
|
All gbq tests passed locally. I created 2 separate conda envs and tested both oauth versions (1.5.0 and 2.0.1). One thing to note is that I had to install PyCrypto when I tested with oauth2client 1.5.0 Here is the output: python 3.5.1 and oauth2client 2.0.1 python 3.5.1 and oauth2client 1.5.0 python 2.7.11 and oauth2client 2.0.1 python 2.7.11 and oauth2client 1.5.0 |
|
Here is the error without pyCrypto installed. Once I install pyCrypto, all tests passed |
|
thanks @parthea I added a bit of documentation w.r.t. the dependencies. Further it might be a nice exercise (and once in place could point to from the docs), to create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff