BUG: SeriesGroupby.nunique raises an IndexError on empty Series #12553 #12560
Conversation
|
needs tests |
jreback
changed the title
|
I'm sry what am I supposed to do? Do you want me to run |
|
new tests, see contributing docs here you have a failing case, so create a test which fails w/o your fix (put the tests in test_groupby.py) then your fix should make it pass |
|
can you rebase / update & add whatsnew for 0.18.2 |
|
can you rebase/update |
Current coverage is 84.12%@@ master #12560 diff @@
==========================================
Files 138 138
Lines 50713 50387 -326
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42715 42385 -330
- Misses 7998 8002 +4
Partials 0 0
|
|
Done, sry for 2 commits but when I try to rebase everything gets messed up... |
| @@ -2833,6 +2833,10 @@ def true_and_notnull(x, *args, **kwargs): | |||
| def nunique(self, dropna=True): | |||
| """ Returns number of unique elements in the group """ | |||
| ids, _, _ = self.grouper.group_info | |||
|
|
|||
| if len(ids) == 0: # bugfix for 12553 | |||
| return Series([]) | |||
|
can you rebase / update |
Author: Thanasis Katsios <[email protected]>
| group = series.groupby(level=0) | ||
| result = group.nunique() | ||
| expected = Series(name='foo') | ||
| assert_series_equal(result, expected) |
There was a problem hiding this comment.
Can you put this test inside the TestGroupBy class? Eg after test_nunique_with_object at Line 6404 (https://github.com/thanasis2028/pandas/blob/744e537c3c73ecb30a62a7707db138b7f4dafcd8/pandas/tests/test_groupby.py#L6400)
|
@thanasis2028 Your change is causing an error in |
|
@thanasis2028 Do you have time to update this PR? |
|
can you rebase / update this? |
|
this was closed by this PR here |
Closes #12553
xref #13239
Made a new pull request to clean up from #12557