Skip to content

TST: Add more period tests #12549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Mar 6, 2016

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • Added some Period related tests in preparation to add period dtype.
  • Moved some tests test_timeseries to correct test class.

@sinhrks sinhrks added Testing pandas testing functions or related to the test suite Period Period data type labels Mar 6, 2016
@sinhrks sinhrks added this to the 0.18.0 milestone Mar 6, 2016
@jreback jreback closed this in 0b1e1c9 Mar 7, 2016
@sinhrks sinhrks deleted the period_test branch March 7, 2016 23:07
jreback pushed a commit that referenced this pull request Apr 1, 2016
 - [x] tests added / passed   - [x] passes ``git diff upstream/master
| flake8 --diff``    - xref #12549   - added more ``Period`` related
tests in preparation for period dtype.

Author: sinhrks <[email protected]>

Closes #12748 from sinhrks/period_test2 and squashes the following commits:

a9295a6 [sinhrks] TST: Add period and other dtype related tests
self.series[5:7] = np.nan
self.assertTrue(np.isnan(self.series[6]))

def test_intercept_astype_object(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinhrks im trying to decipher what this test is aimed at. ring any bells?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Period Period data type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants