ENH: Partial string matching for timestamps with multiindex #12530
+138
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Datetime
|
|
||
| .. ipython:: python | ||
|
|
||
| dft2 = DataFrame(randn(20,1), |
| @@ -22,6 +22,8 @@ New features | |||
| Enhancements | |||
| ~~~~~~~~~~~~ | |||
|
|
|||
| Partial string matches on `DateTimeIndex` now work when part of a `MultiIndex` | |||
There was a problem hiding this comment.
use double-back ticks around DatetimeIndex (sp as well) (and same around MultiIndex); put the issue reference on the same line
|
looks real nice @markroth8 just some minor doc-comments. pls rebase on master when you get a chance; master now builds correctly. |
|
actually pls also put an example in the this section here as well |
|
pls rebase and i'll have a look |
| @@ -22,6 +22,8 @@ New features | |||
| Enhancements | |||
| ~~~~~~~~~~~~ | |||
|
|
|||
| Partial string matches on `DateTimeIndex` now work when part of a `MultiIndex` | |||
| (:issue:`10331`) | |||
|
|
|||
There was a problem hiding this comment.
pls add a min-example here (you can add a sub-section if you'd like to highlite to setup an example and show how it works)
There was a problem hiding this comment.
you can pretty much use the example for timeseries.rst
|
@markroth8 can you update/rebase. |
Includes implementation, unit tests, documentation fixes and whatsnew.
|
@jreback: Incorporated suggestions and rebased / pushed. |
jreback
added a commit
that referenced
this pull request
Mar 21, 2016
jreback
added a commit
that referenced
this pull request
Mar 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffIncludes implementation, unit tests, documentation fixes and whatsnew.