TST: Rework style test skip #12525
Closed
TST: Rework style test skip #12525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Testing
Also redoes some of the changes that were inadvertently revereted in pandas-dev#12260. That PR had two commits, one of which was an older version of what was eventually merged in pandas-dev#12162. The stale commit incorrectly merged was a15248a. It should have been a3c38fe. For the most part the changes were just style, but there was a python2 import error, which our tests didn't fail on because I was trying to catch a jinja ImportError, and instead caught all ImportErrors.
TomAugspurger
force-pushed
the
style-fixups
branch
from
28aae7c to
b014898
Compare
|
I am adding a commit which fixes the 3.4 issue: https://travis-ci.org/jreback/pandas/builds/113805804 issue was a I'll merge on pass. |
|
closed via c387fd8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also redoes some of the changes that were inadvertently reverted
in #12260.
That PR had two commits, one of which was an older version of
what was eventually merged in
#12162.
The stale commit incorrectly merged was a15248a.
It should have been a3c38fe.
For the most part the changes were just style, but there was a python2
import error, which our tests didn't fail on because I was trying to
catch a jinja ImportError, and instead caught all ImportErrors.