TST: Fix NOQA for flake8 checking in datetools.py #12517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to pyflakes suddenly started raising errors in datetools.py due to the star imports at the top, which the "#noqa" was not preventing. The correct syntax is "# flake8: noqa"
|
For anyone out there with permissions to cancel tests on Travis, all of the builds that are right now queued before mine for this PR (#18011) WILL FAIL because of this style checking issue. At the very least, if someone could cancel all of my builds (excluding this one, just search for "gfyoung") as well as cancel any old builds of anyone else's PR's so that this one can land ASAP, that would be great. |
|
there is more, already have these in #12511 maybe we should use a fixed version of pyflakes |
|
Perhaps. I was surprised to see that star import checking popping up relatively late in the game given how many versions have come out already, though discouraging star imports in the general case is understandable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to pyflakes (see here) suddenly started raising errors in
datetools.pydue to the star imports at the top, which the#noqawas not preventing. The correct syntax is# flake8: noqaPLEASE MERGE ASAP