Skip to content

DOC: Add examples and notes to empty documentation #12442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,25 @@ def __contains__(self, key):

@property
def empty(self):
"""True if NDFrame is entirely empty [no items]"""
"""True if NDFrame is entirely empty [no items], i.e. all of the axes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any, not all

are of length 0.

Notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be below examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, do you mean move the entire notes section below examples?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK to leave it here (Jeff, in the html rendered version, the notes will also be before the examples, irregardless of how the order is here)

-----
If NDFrame contains only NaNs, it is still not considered empty.

Examples
--------

>>> # containing only NaNs does not make the df empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a normal sentence (not a comment in the code block), and then leave a blank line between that and the code block on the following lines ?

>>> df = pd.DataFrame({'A' : [np.nan]})
>>> df.empty
False
>>> # if we drop NAs, the axes are now of length 0
>>> df.dropna().empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem as above about the comment + I would also show the output of the actual empty frame

True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a See Also to Series.dropna,DataFrame.dropna

"""
return not all(len(self._get_axis(a)) > 0 for a in self._AXIS_ORDERS)

def __nonzero__(self):
Expand Down