BUG: date_range breaks with tz-aware start/end dates and closed intervals #12409 #12410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
right, but can find where it was changed and add this issue number |
jreback
added
Bug
Regression
| @@ -497,6 +497,25 @@ def test_range_closed(self): | |||
| self.assertTrue(expected_left.equals(left)) | |||
| self.assertTrue(expected_right.equals(right)) | |||
|
|
|||
| def test_range_closed_with_tz_aware_start_end(self): | |||
| begin = Timestamp('2011/1/1', tz='US/Eastern') | |||
There was a problem hiding this comment.
add this issue number here
multiloc
force-pushed
the
bugfix_12409
branch
from
e76692e to
024e6fd
Compare
jreback
changed the title
|
put this issue number in the whatsnew next to #11804 |
|
lgtm. squash; ping when ready. |
multiloc
force-pushed
the
bugfix_12409
branch
from
6278351 to
a40151c
Compare
|
good to go |
|
can you add the test from the issue as well. I am not convinced your tests actually replicate the issue. |
multiloc
force-pushed
the
bugfix_12409
branch
from
a40151c to
ccce839
Compare
|
added more tests covering original issue |
|
ok, looks good. ping when green. |
do comparison for closed intervals on UTC basis prior to tz conversion added tests for date_range covering case of tz-aware start/end dates with closed ranges added issue number to test case update whatsnew added more tests fixed broken unittest
multiloc
force-pushed
the
bugfix_12409
branch
from
ccce839 to
fba0724
Compare
|
good to go |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffdo comparison for closed intervals on UTC basis prior to tz conversion
added tests for date_range covering case of tz-aware start/end dates with closed ranges