BUG: Return UTC DateTimeIndex when specified in to_datetime #12391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tseries/test_timeseries look for similar tests |
gfyoung
force-pushed
the
to_datetime_utc
branch
2 times, most recently
from
3ffc110 to
4c5228e
Compare
|
@jreback : All tests are passing. Should be good to merge then. |
| date_index = pd.to_datetime(df.index, utc=True) | ||
|
|
||
| expected = 'datetime64[ns, UTC]' | ||
| out_dtype = str(date_index.dtype) |
There was a problem hiding this comment.
construct an actual DatetimeIndex as the expect d result and use assert_index_equal
you don't need to construct the DataFrame here as you are only using the index
gfyoung
force-pushed
the
to_datetime_utc
branch
from
4c5228e to
fa794a5
Compare
|
@jreback : All tests are passing. Should be good to merge then. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory. Closes #11934.