Skip to content

BUG: Fix bug where sort_index if unsorted levels. #12342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

BUG: Fix bug where sort_index if unsorted levels. #12342

wants to merge 1 commit into from

Conversation

tshauck
Copy link
Contributor

@tshauck tshauck commented Feb 16, 2016

Closes #12261

@tshauck
Copy link
Contributor Author

tshauck commented Feb 16, 2016

Not sure if this is the best way to solve this, but it looks like the bug in #12261 is because the labels are sorted, but the levels aren't.

It seems like the better way is is_lexsorted should return False if the levels aren't sorted because you could get the potential mismatch, but that's a layer below this issue so I didn't want to touch it.

@jreback
Copy link
Contributor

jreback commented Feb 16, 2016

this is not the right way to go about this.

@tshauck
Copy link
Contributor Author

tshauck commented Feb 16, 2016

Ok... Does this help you see what this issue is enough (you didn't seem to have an idea from the issue*) to recommend what the appropriate path would be?

  • Seems to be the level sorting issue unless it's a red herring.

@jreback
Copy link
Contributor

jreback commented Feb 16, 2016

yeh I haven't really delved into it much.

@tshauck
Copy link
Contributor Author

tshauck commented Feb 16, 2016

Ok...

@tshauck tshauck closed this Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants