Skip to content

BUG: Series.plot() doesn't work with CustomBusinessDay frequency #12294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: Series.plot() doesn't work with CustomBusinessDay frequency #12294

wants to merge 1 commit into from

Conversation

scari
Copy link
Contributor

@scari scari commented Feb 11, 2016

Closes #7222
Missing freqstr 'C' in _period_code_map
I found pandas/tseries/tests/test_frequencies.py:TestFrequencyCode.test_freq_code cover this change.

@jreback
Copy link
Contributor

jreback commented Feb 11, 2016

tests!

@scari
Copy link
Contributor Author

scari commented Feb 11, 2016

pandas/tseries/tests/test_frequencies.py:TestFrequencyCode.test_freq_code cover _period_code_map change itself.
however, I think it's also good idea to add a test on test_graphics.py since the original issue was related on plotting.

be back soon.

@scari
Copy link
Contributor Author

scari commented Feb 11, 2016

added a test.

@scari scari force-pushed the master branch 2 times, most recently from afabb23 to 83ca60f Compare February 12, 2016 13:21
@jreback jreback added this to the 0.18.0 milestone Feb 12, 2016
@jreback jreback closed this in 3e4c572 Feb 12, 2016
@jreback
Copy link
Contributor

jreback commented Feb 12, 2016

thanks @scari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Visualization plotting
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@scari @jreback