BUG: Ensure data_columns is always a list (i.e. min_itemsize can exte… #12252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2016
Closed
| @@ -3247,7 +3247,7 @@ def validate_data_columns(self, data_columns, min_itemsize): | |||
| # evaluate the passed data_columns, True == use all columns | |||
| # take only valide axis labels | |||
| if data_columns is True: | |||
| data_columns = axis_labels | |||
| data_columns = list(axis_labels) | |||
There was a problem hiding this comment.
this type coercion will fail if you pass a string
There was a problem hiding this comment.
in fact this should be not done here at all. The data_columns should be cleaned in a central location (IIRC they already are and just needs an adjustment)
|
can you rebase/update |
|
can you rebase / update & add whatsnew for 0.18.2 |
|
can you update according to comments |
|
can you rebase / update? |
|
Yeah, I'm just trying to focus on one PR at a time to limit (my) confusion... but this will be the next. |
|
sure no prob |
|
can you rebase / update? |
|
Not next week, I fear, but yes the one after. |
|
closing, but pls reopen / comment if you can continue |
|
See #14728 (sorry for the long wait) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd it)
closes #10381