BUG: Timestamp subtraction of NaT with timezones #12241
Closed
+178
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Bug
Missing-data
| result = self._maybe_mask_results(result, fill_value=tslib.iNaT) | ||
| if other is tslib.NaT: | ||
| result = np.zeros(len(self), dtype=np.int64) | ||
| result.fill(tslib.iNaT) |
There was a problem hiding this comment.
these 2 lines should be a private function in tseries/base.py somewhere.
sinhrks
force-pushed
the
nat_ops
branch
4 times, most recently
from
bb06973 to
06cab78
Compare
|
|
||
| from pandas.tseries.period import PeriodIndex | ||
| attribs = self._get_attributes_dict() | ||
| if not isinstance(self, PeriodIndex): |
There was a problem hiding this comment.
you can use ABCPeriodIndex
|
@sinhrks one small comment. looks much cleaner. thanks. merge when green (or ping and I can). |
|
Thanks, fixed to use |
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11718.
NaTandTimestampwithtzresults inNaTNaTandDatetimeIndex/TimedeltaIndexresults in correspondingIndexfilled withNaT.