DEPR: some removals #12165
Closed
DEPR: some removals #12165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted() and DataFrame.drop_duplicates(), xref pandas-dev#6680
|
removing the float indexers change as it is a rabbit hole :) (meaning a different PR!) |
1 task
| @@ -233,8 +233,6 @@ class Timestamp(_Timestamp): | |||
| Offset which Timestamp will have | |||
| tz : string, pytz.timezone, dateutil.tz.tzfile or None | |||
| Time zone for time which Timestamp will have. | |||
| unit : string | |||
| numpy unit used for conversion, if ts_input is int or float | |||
There was a problem hiding this comment.
Is there a reason you removed this?
As I think it is a valid kwarg?
In [155]: pd.Timestamp(5, unit='D')
Out[155]: Timestamp('1970-01-06 00:00:00')
There was a problem hiding this comment.
shoot, you are right. was looking at something else. will revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPR: Removal of cols keyword in favor of subset in DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680