CLN: reorganize index.py, test_index.py #12124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
changed the title
|
Once the build passes, best not to let this patch linger (to avoid rebase conflicts). @jreback I don't think I broke anything but let me know if any concerns that I can look into |
|
The python 2 tests are still failing, I think you missed a |
|
Thanks, think I got it now. Will check the build in an hour or two here |
|
@jorisvandenbossche @jreback merge when ready. thank you |
| InvalidIndexError) | ||
| from .category import CategoricalIndex # noqa | ||
| from .multi import MultiIndex # noqa | ||
| from .numeric import NumericIndex, Float64Index, Int64Index # noqa |
There was a problem hiding this comment.
the relative imports are not consistent with the rest of the import methodology. Ok, but should define when relative imports are ok.
|
OK, cleaned up things per your comments. |
|
lgtm. ping when green. |
|
@jreback we are good to go |
|
boo ya! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split apart these two very large modules and created a new
pandas.indexessubpackage. It would be nice to move all the index class code frompandas.tseriesthere in a followup patch.