-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Add Zip file functionality. Fixes #11413 #12103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7f3461c
Add Zip file functionality. Fixes #11413
2fc43b6
Add test to ensure ValueError is thrown when ZIP file contains multip…
f5a641d
Add parser description warning to handle ZIP files
lababidi cf7c347
Create TestCompression Nose Test Class. Split test_compression into t…
1b21456
Merge remote-tracking branch 'origin/master'
b6939ea
Merge branch 'master' of github.com:pydata/pandas
56e55a6
Add Zip file functionality. Fixes #11413
40fe268
Add test to ensure ValueError is thrown when ZIP file contains multip…
ee336f1
Add parser description warning to handle ZIP files
lababidi 1c3ecd7
Create TestCompression Nose Test Class. Split test_compression into t…
b3c21cf
Merge branch 'master' of github.com:lababidi/pandas
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -563,6 +563,18 @@ cdef class TextReader: | |
else: | ||
raise ValueError('Python 2 cannot read bz2 from open file ' | ||
'handle') | ||
elif self.compression == 'zip': | ||
import zipfile | ||
zip_file = zipfile.ZipFile(source) | ||
zip_names = zip_file.namelist() | ||
|
||
if len(zip_names) == 1: | ||
file_name = zip_names.pop() | ||
source = zip_file.open(file_name) | ||
|
||
else: | ||
raise ValueError('Multiple files found in compressed ' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe just do |
||
'zip file %s', str(zip_names)) | ||
else: | ||
raise ValueError('Unrecognized compression type: %s' % | ||
self.compression) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add an explanation about .zip is only a single file