PEP: pandas/core round 4 (indexing, internals, missing) #12074
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,7 +216,8 @@ def _setitem_with_indexer(self, indexer, value): | |||
| self._has_valid_setitem_indexer(indexer) | |||
|
|
|||
| # also has the side effect of consolidating in-place | |||
| from pandas import Panel, DataFrame, Series | |||
| # TODO: Panel, DataFrame are not imported, remove? | |||
There was a problem hiding this comment.
why is this added? these are not imported because it would be a circluar import otherwise (the NDFrame objects need to import the indexers to make them properties).
There was a problem hiding this comment.
Should read "are not used". They aren't used anywhere.
|
minor comment. lgtm |
|
thanks @rockg ! I can attest this is not the most pleasant sort of work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.