BUG: GH12050 Setting values on Series using .loc with a TZ-aware DatetimeIndex fails #12054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix has been derived from similar code in the method _getitem_iterable around line 980 of indexing.py . Somebody with a better knowledge about the interplay of all the functions should comment before merging. |
|
tests! |
coroa
force-pushed
the
master
branch
2 times, most recently
from
3012661 to
380ba35
Compare
|
Is this one good enough? Or should I also test for variations? |
| @@ -3511,6 +3511,17 @@ def test_loc_setitem_datetime(self): | |||
| expected = DataFrame({'one' : [100.0, 200.0]},index=[dt1, dt2]) | |||
| assert_frame_equal(df, expected) | |||
|
|
|||
| def test_loc_setitem_datetimeindex(self): | |||
There was a problem hiding this comment.
pls add the full gamut here (get/setitem) and .loc get/set. also make a loop and test index, list-like, single indexer.
(these all work, but covering bases).
put these tests near these existing ones on https://github.com/pydata/pandas/blob/master/pandas/tests/test_indexing.py#L856
jreback
added
Bug
Indexing
|
pls also add a release note (bug fixes) |
Ready for merging from where i sit. |
|
merged via 4182105 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12050 .
Taking just the values of an index object looses the timezone information.