MAINT: Make take_1d accept readonly buffers. #12033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
the
Compat
|
ok, pls add a release note (you can put in bug fixes). ping on green. |
This is a straightforward port of GH#10070 to 1d arrays.
jvkersch
force-pushed
the
fix/readonly-take-1d
branch
from
61513cf to
476c37a
Compare
|
@jreback release note added |
|
merged via 5d8cbb2 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of @ogrisel's fix in #10070 to deal with 1d arrays. There's absolutely nothing new here beyond what's in the original patch.
closes #11502