BUG: remove millisecond field that raises valueerror #12019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
force-pushed
the
remove-millisecond-field
branch
from
8c03dab to
57b5ef3
Compare
|
yeh, I think this was historicaly left in. can you add a test (assert that it raises), so when someone tries to add it back it will fail!. ping on green. |
llllllllll
force-pushed
the
remove-millisecond-field
branch
from
57b5ef3 to
9501758
Compare
|
Added the test, build is now passing |
jreback
added a commit
that referenced
this pull request
Jan 12, 2016
BUG: remove millisecond field that raises valueerror
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would appear in the
dirand cause tab completion to a field that would raise aValueError. When I brought this up in gitter it seemed like it was safe to remove it.I couldn't find any tests that hit this descriptor.