Small improvements to str_cat #12000
Conversation
…prompt more clearly for a sep keyword
…prompt more clearly for a sep keyword
|
tests! |
jreback
added
Missing-data
| @@ -2057,6 +2059,17 @@ def test_method_on_bytes(self): | |||
| 'S2').astype(object)) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_str_cat_raises_intuitive_error(self): | |||
| s = Series(['a','b','c','d']) | |||
There was a problem hiding this comment.
add the issue number as a comment here
|
pls also add entries in whatsnew (one for each of the bug fixes). we'll call ignoring nans a bug fix. |
|
can you rebase / update |
CLN: remove core/matrix.py, not imported into the pandas namespace
Added test cases for `_min_fitting_element` and `_max_fitting_element` (unused) that would fail in master because of precision Author: Ka Wo Chen <[email protected]> Closes pandas-dev#12113 from kawochen/CLN-RI-max-fitting and squashes the following commits: 3cbc7f5 [Ka Wo Chen] CLN: cleaned RangeIndex._min_fitting_element
Author: Wes McKinney <[email protected]> Closes pandas-dev#12114 from wesm/style/stats and squashes the following commits: a3f8508 [Wes McKinney] CLN: fix flake8 warnings in pandas/stats
Author: Wes McKinney <[email protected]> Closes pandas-dev#12115 from wesm/style/flake8-misc and squashes the following commits: 017ca16 [Wes McKinney] CLN: grab bag of flake8 fixes
…prompt more clearly for a sep keyword
…N in case of array with NaN.
|
I may have just botched this... tried rebasing on master and now there are many changes I didn't include reflected in the diff. |
|
http://pandas.pydata.org/pandas-docs/stable/contributing.html#contributing-your-changes-to-pandas
then
|
|
You have to make sure your your master is in sync with upstream master. You can revert to your original patch with "git reset --hard HASH" -- look in your git reflog to find the commit hash. |
|
This was botched and left to languish-- have restarted and will ref this in the re-do. |
closes #11435
closes #11334.
Added some doc examples to make the behavior with
nanmore clear, and catch an error condition when asepis passed instead of anothers(array) as an argument and print a more intuitive error message.