WIP/PEP8: pandas/core

[rockg]

xref #11928

Putting this out there as a start. Will add to this over the next couple of days.

[jreback]

just merged: #11941

will show the linting effect in travis (though not fail because of it).

FYI, I have found autopep8 does a pretty good job (though doesn't fix long lines)

[jreback]

I am also ok with doing this in sections (3 files sounds about right). So when one is ready to go. pls ping.

[rockg]

green...there are still a few E731 lambda should be def, but substantially better than before.

[jorisvandenbossche]

There should not be a indentation here I think

[jorisvandenbossche]

@rockg can you specify what you exactly did? Is this the result of an automated tool (autopep8), or from manual clean-up?
Because I not fully 'happy' with all style changes, but if it is the result of a tool, then it will be probably easier to just accept the particular style of that tool (as style will always be something subjective).

Apart from that I put some comments of things that are not subjective.

[rockg]

Manual with the aid of editor defaults for line continuation, etc. I'm happy to go through and change any persistent issues, but my main goal here was to result in no output from flake8.

[rockg]

As 90% of the issues are long-lines and autopep8 doesn't do that I felt it was easier to do manually.

[kawochen]

--max-line-length 79 as an option to autopep8

[jreback]

that reminds me - we should recommend autopep8

any way to setup default options? like we do for flake8

[TomAugspurger]

Looks like it

  --ignore-local-config
                        don't look for and apply local config files; if not
                        passed, defaults are updated with any config files in
                        the project's root directory

it seem to look for a file called .pep8 https://github.com/hhatto/autopep8/blob/9eb1121f357077c7d71fc770e25d3678f906a401/autopep8.py#L122

[rockg]

Yes, seems that it does. I was only going on the comment above. Is it in such a state to use autopep8 for this set or only do that for future ones?

[rockg]

For eventual continuity with the rest of the source, I'll use autopep8 and repush.

[jreback]

can u add in the config file for autopep8 as well

[jreback]

thanks @rockg