CLN: Use is operator for comparing with None (Pep8)
#11828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -293,15 +293,15 @@ def test_none_comparison(self): | |||
|
|
|||
| o[0] = np.nan | |||
|
|
|||
| result = o == None | |||
| result = o is None | |||
There was a problem hiding this comment.
these all need to be left alone, these are explicity testing ==
|
I've reverted the changes to that file. |
|
@proinsias yes having a comment is ok to prevent linters from finding this is fine |
|
ping when updated |
|
I've updated the pull request to avoid modifying the test code, and to add #noinspection comments in the test code. |
jreback
added a commit
that referenced
this pull request
Dec 15, 2015
CLN: Use `is` operator for comparing with `None` (Pep8)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.