BUG: to_numeric should raise if input is more than one dimension #11776 #11780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif getattr(arg, 'ndim', None) == 1: | ||
| pass | ||
| else: | ||
| raise TypeError('arg must be a list, tuple, 1-d array, or Series') |
There was a problem hiding this comment.
fix the doc-string to match this
|
pls add a whats new note (you can do in bug fixes) |
jreback
added
API Design
Error Reporting
mortada
force-pushed
the
to_numeric_should_raise_on_df
branch
from
a7ab458 to
db3994b
Compare
| @@ -37,7 +37,7 @@ def to_timedelta(arg, unit='ns', box=True, errors='raise', coerce=None): | |||
|
|
|||
| def _convert_listlike(arg, box, unit, name=None): | |||
|
|
|||
| if isinstance(arg, (list,tuple)) or ((hasattr(arg,'__iter__') and not hasattr(arg,'dtype'))): | |||
| if isinstance(arg, (list, tuple)) or not hasattr(arg, 'dtype'): | |||
There was a problem hiding this comment.
note that there's no need to check hasattr(arg,'__iter__') because is_list_like already checks for that
mortada
force-pushed
the
to_numeric_should_raise_on_df
branch
2 times, most recently
from
bd9f25a to
a44f8be
Compare
|
@jreback it's updated |
mortada
force-pushed
the
to_numeric_should_raise_on_df
branch
from
a44f8be to
dc2a5b3
Compare
|
@jreback @jorisvandenbossche updated again |
|
travis is green now |
jreback
added a commit
that referenced
this pull request
Dec 10, 2015
BUG: to_numeric should raise if input is more than one dimension #11776
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11776