MNT: simplify AutoDateFormatter #11770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- import constants from matplolib.dates - do not re-implement AutoDateFormatter functionality that is already upstream
|
can you show an example of where this was doing the wrong thing? (e.g. a test for this) |
|
There is nothing wrong, it just was an almost copy-paste job from mpl to pandas. This change should have 0 functional change. |
|
ok, seems like we were just overriding mpl code. Since everything passed, this either was never tested (probably), or works ok :) |
jreback
added a commit
that referenced
this pull request
Dec 8, 2015
MNT: simplify AutoDateFormatter
| 30.: '%b %Y', | ||
| 1.0: '%b %d %Y', | ||
| 1. / 24.: '%H:%M:%S', | ||
| 1. / 24. / 3600. / 1000.: '%H:%M:%S.%f' |
There was a problem hiding this comment.
Found the difference between what was here and what is in MPL it is the extra 1000 in the last entry.
I will have a PR shortly.
tacaswell
added a commit
to tacaswell/pandas
that referenced
this pull request
May 12, 2016
Reverts part of: pandas-dev#11770 Closes: matplotlib/matplotlib#6365 The mistake in pandas-dev#11770 was missing that pandas had a 1/us not 1/s scaled bucket.
jreback
pushed a commit
that referenced
this pull request
May 20, 2016
revert part of #11770 xref: matplotlib/matplotlib#6365 closes #13131 The mistake in #11770 was missing that pandas had a 1/us not 1/s scaled bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is already upstream