Truncated float support for SAS Xport files #11713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems reasonable. can you add a whats note in enhancements. |
kshedden
force-pushed
the
xport_float32
branch
from
1f829e8 to
f251612
Compare
jreback
pushed a commit
that referenced
this pull request
Dec 1, 2015
|
merged via 547750a thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAS xport files allow floats to be stored with fewer than 8 bytes, with implicit zeros in the high order bytes. Currently we only handle full width (8 byte) floats. This PR adds support for truncated floats.