Skip to content

BUG: style.bar results in incorrect gradient using specific browser #11678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Nov 23, 2015

It's not a bug on pandas side, but CSS linear-gradient with 0% width seems not be rendered properly using specific browsers.

Below is the output using Mac OSX 10.10.5 / Firefox.

2015-11-23 10 53 47

The fix simply exclude linear-gradient if its width is 0.

After the fix (same environment)

2015-11-23 10 54 18

@sinhrks sinhrks added Output-Formatting __repr__ of pandas objects, to_string IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Nov 23, 2015
@sinhrks sinhrks added this to the 0.18.0 milestone Nov 23, 2015
@jreback
Copy link
Contributor

jreback commented Nov 29, 2015

@TomAugspurger ?

@sinhrks lgtm. (prob a whatsnew conflict)

@@ -195,5 +195,9 @@ Bug Fixes

- Bug in ``.loc`` result with duplicated key may have ``Index`` with incorrect dtype (:issue:`11497`)
- Bug in ``pd.rolling_median`` where memory allocation failed even with sufficient memory (:issue:`11696`)
- Bug in ``.loc`` against ``CategoricalIndex`` may result in normal ``Index`` (:issue:`11586`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this extra note sneak in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed.

jreback added a commit that referenced this pull request Dec 10, 2015
BUG: style.bar results in incorrect gradient using specific browser
@jreback jreback merged commit a7669d0 into pandas-dev:master Dec 10, 2015
@jreback
Copy link
Contributor

jreback commented Dec 10, 2015

thank you sir!

@sinhrks sinhrks deleted the style_bar branch December 12, 2015 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants