BUG: vectorized DateOffset match non-vectorized #11427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-b1 can you rebase / update |
|
#11777 merged! pls update |
chris-b1
force-pushed
the
offset-zero
branch
from
4166da6 to
ac83a2a
Compare
chris-b1
changed the title
|
@jreback - updated |
jreback
added a commit
that referenced
this pull request
Dec 13, 2015
BUG: vectorized DateOffset match non-vectorized
|
lgtm! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11370
Also added a bit of documentation on the semantics for anchored offsets
currently blocked by #11406 - either need to change the vectorized or non-vectorized implementation of
QuarterBeginAs discussed in that issue, my opinion is the vectorized version is the "right" (or at least consistent) one.