Skip to content

fixed pathlib tests on windows #11362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2015
Merged

fixed pathlib tests on windows #11362

merged 1 commit into from
Oct 18, 2015

Conversation

flying-sheep
Copy link
Contributor

as requested here: #11033 (comment)

i can’t test on windows unfortunately.

@flying-sheep flying-sheep mentioned this pull request Oct 18, 2015
Closed
@jreback
Copy link
Contributor

jreback commented Oct 18, 2015

use this

In [6]: os.path.join('',*['foo','bar'])
Out[6]: 'foo/bar'

@jreback jreback added Bug IO Data IO issues that don't fit into a more specific label labels Oct 18, 2015
@jreback jreback added this to the 0.17.1 milestone Oct 18, 2015
@flying-sheep
Copy link
Contributor Author

much easier: os.path.join('foo', 'bar')

@jreback
Copy link
Contributor

jreback commented Oct 18, 2015

@flying-sheep right!

ok ping on green.

@jreback
Copy link
Contributor

jreback commented Oct 18, 2015

passes on windows

@flying-sheep
Copy link
Contributor Author

ping!

jreback added a commit that referenced this pull request Oct 18, 2015
@jreback
Merge pull request #11362 from flying-sheep/pathlib-testfix
f081722 
fixed pathlib tests on windows
@jreback jreback merged commit f081722 into pandas-dev:master Oct 18, 2015
@jreback
Copy link
Contributor

jreback commented Oct 18, 2015

thanks!

@flying-sheep flying-sheep deleted the pathlib-testfix branch October 18, 2015 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
0.17.1
Development

Successfully merging this pull request may close these issues.
2 participants
@flying-sheep @jreback