BUG: to_excel duplicate columns #11237
Merged
+41
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.rowcounter = 0 | ||
| self.na_rep = na_rep | ||
| self.columns = cols | ||
| if cols is None: | ||
| if cols is not None: |
There was a problem hiding this comment.
self.df = df
if cols is not None:
self.df = self.df.reindex(columns=cols)
self.columns = self.df.columns
|
@jreback - updated for youf comments. |
| @@ -1375,6 +1388,22 @@ def test_swapped_columns(self): | |||
| tm.assert_series_equal(write_frame['A'], read_frame['A']) | |||
| tm.assert_series_equal(write_frame['B'], read_frame['B']) | |||
|
|
|||
| def test_invalid_columns(self): | |||
| _skip_if_no_xlrd() | |||
|
pls squash otherwise lgtm. |
|
Nice! |
|
can you rebase/squash |
chris-b1
force-pushed
the
excel-column-bugs
branch
from
eae8124 to
dba4d1f
Compare
|
@jreback this is squashed now |
jreback
added a commit
that referenced
this pull request
Oct 10, 2015
BUG: to_excel duplicate columns
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11007
closes #10970 (data in wrong order)
closes #10982 (columns lost).
Using the approach suggested here
All three occurred when using
to_excelwith duplicate columns in theDataFrame