squeeze works on 0 length arrays #11230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1717,6 +1717,10 @@ def test_squeeze(self): | |||
| p4d = tm.makePanel4D().reindex(labels=['label1'],items=['ItemA']) | |||
| tm.assert_frame_equal(p4d.squeeze(),p4d.ix['label1','ItemA']) | |||
|
|
|||
| # don't fail with 0 length dimensions | |||
| empty=pd.DataFrame(pd.np.empty(shape=(0,1))) | |||
There was a problem hiding this comment.
test with all shapes here (series.frame,etc)
furthermore this should preserve name
|
@jreback tests added |
|
What should the behavior be here: empty_series=pd.Series([], name='five').squeeze()numpy returns itself: In [18]: pd.np.empty(0)
Out[18]: array([], dtype=float64)
In [19]: pd.np.empty(0).squeeze()
Out[19]: array([], dtype=float64)...which is the current pandas implementation too. |
|
no squeeze does not return a scalar always a Series (or high dim) |
|
OK @jreback, test added for that too |
|
Also closes #8999 |
|
their is a whatsnew for 0.17.1 pls add a release note. |
|
@jreback what's new added, commits squashed, ready to go from this end |
| @@ -42,3 +42,5 @@ Performance Improvements | |||
|
|
|||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - Bug in `squeeze` with zero length arrays (:issue:`11230`) & (:issue:`8999`) | |||
There was a problem hiding this comment.
use double-backtickers (and say .squeeze())
list issues like: (:issue: 11230, :issue:8999)
|
@jreback done! |
|
merged via aa94ae4 thanks! |
This was referenced Oct 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #11229.
fixes: #8999.
Also a better implementation that avoids
ixShould I add to What's new for 0.17? Or is that closed now?