BUG: Issue in the gbq module when authenticating on remote servers #8489 #11141
+86
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
force-pushed
the
bq-auth-on-remote-servers
branch
from
a75f99b to
114aab5
Compare
|
Travis is green |
| @@ -133,7 +132,9 @@ def get_credentials(self): | |||
| credentials = storage.get() | |||
|
|
|||
| if credentials is None or credentials.invalid or self.reauth: | |||
| credentials = run_flow(flow, storage, argparser.parse_args([])) | |||
| print('Go to the following link in your browser: {0}'.format(flow.step1_get_authorize_url())) | |||
There was a problem hiding this comment.
not a big fan of this. I would simply raise with an intelligble message.
jreback
added
Google I/O
Error Reporting
|
@parthea can you update, I think should just raise an informative message |
parthea
force-pushed
the
bq-auth-on-remote-servers
branch
from
114aab5 to
99bf170
Compare
|
I'm still working on this PR. I removed my last commit, which automatically closed the pull request. It should open when I submit a new commit. I want to provide users with a simple way to create the required Then I can raise an informative error message if the credentials are missing or invalid which tells the user to first call the |
|
@parthea |
|
Add |
parthea
force-pushed
the
bq-auth-on-remote-servers
branch
6 times, most recently
from
ac915d6 to
c0d5ec9
Compare
|
All tests passed in my local environment. Waiting on travis. |
|
Ready for review. Travis is green. |
parthea
force-pushed
the
bq-auth-on-remote-servers
branch
from
c0d5ec9 to
cd3221b
Compare
parthea
force-pushed
the
bq-auth-on-remote-servers
branch
from
cd3221b to
55764ea
Compare
| @@ -128,23 +130,44 @@ def test_google_api_imports(self): | |||
| except ImportError as e: | |||
| raise ImportError("Missing module required for Google BigQuery support: {0}".format(str(e))) | |||
|
|
|||
| def get_credentials(self): | |||
| def authorize(self): | |||
There was a problem hiding this comment.
no, you must have the credentials to pass in. pandas shouldn't be responsiblet for saving/retriveing these. .authorize should be almost a trivial call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue where gbq authentication on remote servers fails silently.