COMPAT: Add Google BigQuery support for python 3 #11094 #11110
Merged
+51
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Python 3.5 unit tests are failing, waiting on #11097 |
|
@parthea yes, 3.5 are ok |
|
Some gbq unit tests are failing on Python 3.4 I think I need to remove the |
parthea
force-pushed
the
gbq-python3
branch
from
c1b2390 to
ef949b1
Compare
|
@parthea gr8. let me know when ready for review. |
|
whatsnew note as well. |
|
add a whatsnew entry (in the gbq sub-section that you did before). |
|
Can I wait for #11121 to be merged? |
parthea
force-pushed
the
gbq-python3
branch
3 times, most recently
from
49ec34e to
8602e1d
Compare
|
ok, rebase this, ping when green. |
|
@aaront You are welcome to work on this if you have time, but don't feel obligated. I plan to commit a new version tomorrow evening. |
|
Travis is green |
| @@ -353,10 +357,15 @@ def _parse_data(schema, rows): | |||
|
|
|||
| fields = schema['fields'] | |||
| col_types = [field['type'] for field in fields] | |||
| col_names = [field['name'].encode('ascii', 'ignore') for field in fields] | |||
| if compat.PY2: | |||
| col_names = [field['name'].encode('ascii', 'ignore') for field in fields] | |||
There was a problem hiding this comment.
hmm, does BigQuery require ascii column names? e.g. doesn't support say utf-8?
There was a problem hiding this comment.
utf-8 is ok. I think the conversion to ascii was a workaround for an unrelated issue numpy/numpy#2407
For python 3 compatability, we can just use str( ) . I've committed a new version.
|
can you certify that all tests are passing on py2 and py3? (as we skip the actual tests on travis). |
parthea
force-pushed
the
gbq-python3
branch
from
1f180ee to
107b21f
Compare
|
Ready for review. All tests pass locally. Python 2.7 test results Python 3.4 test results |
jreback
added a commit
that referenced
this pull request
Sep 27, 2015
COMPAT: Add Google BigQuery support for python 3 #11094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11094
Adds gbq support for python 3.4