BUG: .ix with PeriodIndex is fixed #11015
Conversation
| import pandas.tslib as tslib | ||
| import pandas.lib as lib | ||
| import pandas.algos as _algos | ||
| import pandas.index as _index | ||
| from pandas.lib import Timestamp, Timedelta, is_datetime_array | ||
|
|
||
| from pandas.compat import range, zip, lrange, lzip, u, map | ||
| from pandas import compat |
There was a problem hiding this comment.
This stuff is PyCharm - I can revert if you want
jreback
added
Bug
Indexing
| @@ -973,7 +976,9 @@ def _convert_list_indexer(self, keyarr, kind=None): | |||
| and we have a mixed index (e.g. number/labels). figure out | |||
| the indexer. return None if we can't help | |||
| """ | |||
| if (kind is None or kind in ['iloc','ix']) and (is_integer_dtype(keyarr) and not self.is_floating()): | |||
| if (kind is None or kind in ['iloc', 'ix']) and ( | |||
| is_integer_dtype(keyarr) and not self.is_floating() and not isinstance(keyarr, ABCPeriodIndex)): | |||
There was a problem hiding this comment.
use com.is_period_arraylike
There was a problem hiding this comment.
though you might simply be able to define _convert_list_indexer in PeriodIndex to handle this in a nicer way
There was a problem hiding this comment.
Agree for most cases - when you have a PeriodIndex and you supply another as an index.
But if you have an integer index and someone supplies a PeriodIndex as the key, I don't think you want that resolving to its ints. Does that make sense?
Would this be solved if we had a Period dtype? I couldn't find an open issue about that, but I think you've mentioned it a few times
There was a problem hiding this comment.
period dtype would fix this but that's for the future
period right now is an integer dtype and that's the problem it's confused
max-sixty
force-pushed
the
period-index-er
branch
from
b5544ca to
099292e
Compare
max-sixty
force-pushed
the
period-index-er
branch
from
099292e to
225bb34
Compare
| if (kind is None or kind in ['iloc','ix']) and (is_integer_dtype(keyarr) and not self.is_floating()): | ||
| if (kind is None or kind in ['iloc', 'ix']) and ( | ||
| is_integer_dtype(keyarr) and not self.is_floating() and not com.is_period_arraylike(keyarr)): | ||
|
|
There was a problem hiding this comment.
on 2nd thought, this is going to cause a perf issue ,change this to isinstance(keyarr, ABCPeriodIndex) (you can import this at the top.
|
pls add a whatsnew note |
|
merged via 879f5e9 thanks! (I changed this slightly in another commit). |
|
Cheers @jreback! |
Solves #4125
It doesn't feel like an elegant solution, but I think it works.
I think when Period gets its own dtype, these will all go away?