Skip to content

DOC: Consistent variable names (sheetname vs sheet_name, issue 10559) #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

terrytangyuan
Copy link
Contributor

See issue #10559. Done testing after the changes.

@jorisvandenbossche
Copy link
Member

@terrytangyuan the tests are failing because you changed the keyword names as well in the implementation, where this depends on the libraries used by pandas (xlrd, openpyxl, etc). So you also have to check there what name they are using.

@terrytangyuan
Copy link
Contributor Author

@jorisvandenbossche Thanks. I tried but failed again. It's hard to deal with those internal usages. Might just leave this task to people who are more familiar with them.

@terrytangyuan terrytangyuan deleted the PR5 branch September 4, 2015 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants