-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Revert "Revert "Merge pull request #10727 from jorisvandenbossche/sph… #10925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…inx-traceback"
This is becoming a nice title Revert of revert of ... :-) Just opening this, so I can grab this and only change the syntaxerror to a code-block, to see if that lets travis build the docs correctly. |
Hmm, still not working .. |
@@ -498,6 +494,16 @@ def process_input(self, data, input_prompt, lineno): | |||
sys.stdout.write(s) | |||
sys.stdout.write('<<<' + ('-' * 73) + '\n') | |||
|
|||
# if :okexcept: has been specified, display shorter traceback | |||
if is_okexcept and "Traceback" in output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps
if is_okexcept and ("Traceback" in output or "SyntaxError" in output):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kawochen Thanks for the idea. That would indeed be a solution to also get the SyntaxError working with this.
But, it does not really explain why this just aborts on travis, because I left out the SyntaxError with the latest commit ..
@jorisvandenbossche status for this? |
1 similar comment
@jorisvandenbossche status for this? |
@jorisvandenbossche close this? |
@jorisvandenbossche keep open? |
@jorisvandenbossche status of this? |
@jorisvandenbossche closing as a PR. maybe create an issue for this? |
Reverts #10916