Skip to content

Revert "Revert "Merge pull request #10727 from jorisvandenbossche/sph… #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jorisvandenbossche
Copy link
Member

Reverts #10916

@jorisvandenbossche
Copy link
Member Author

This is becoming a nice title Revert of revert of ... :-)

Just opening this, so I can grab this and only change the syntaxerror to a code-block, to see if that lets travis build the docs correctly.

@jorisvandenbossche
Copy link
Member Author

Hmm, still not working ..

@jorisvandenbossche jorisvandenbossche added this to the 0.17.0 milestone Aug 29, 2015
@@ -498,6 +494,16 @@ def process_input(self, data, input_prompt, lineno):
sys.stdout.write(s)
sys.stdout.write('<<<' + ('-' * 73) + '\n')

# if :okexcept: has been specified, display shorter traceback
if is_okexcept and "Traceback" in output:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

if is_okexcept and ("Traceback" in output or "SyntaxError" in output):

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kawochen Thanks for the idea. That would indeed be a solution to also get the SyntaxError working with this.

But, it does not really explain why this just aborts on travis, because I left out the SyntaxError with the latest commit ..

@jreback
Copy link
Contributor

jreback commented Sep 13, 2015

@jorisvandenbossche status for this?

1 similar comment
@jreback
Copy link
Contributor

jreback commented Sep 25, 2015

@jorisvandenbossche status for this?

@jreback jreback modified the milestones: 0.17.0, 0.17.1 Oct 2, 2015
@jreback
Copy link
Contributor

jreback commented Oct 25, 2015

@jorisvandenbossche close this?

@jreback
Copy link
Contributor

jreback commented Nov 13, 2015

@jorisvandenbossche keep open?

@jreback jreback modified the milestones: Next Major Release, 0.17.1 Nov 18, 2015
@jreback
Copy link
Contributor

jreback commented Dec 16, 2015

@jorisvandenbossche status of this?

@jreback
Copy link
Contributor

jreback commented Jan 6, 2016

@jorisvandenbossche closing as a PR. maybe create an issue for this?

@jreback jreback closed this Jan 7, 2016
@jreback jreback deleted the revert-10916-de branch February 12, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants