API: Closes #7879: (drops not nan in panel.to_frame() by default) #10908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensing
force-pushed
the
panel_to_frame_fix
branch
from
ba83a39 to
cee665d
Compare
hensing
changed the title
| @@ -867,7 +868,7 @@ def to_frame(self, filter_observations=True): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| filter_observations : boolean, default True | |||
There was a problem hiding this comment.
leave this in (and say its deprecated)
|
this will need a sub-section in whatsnew/0.17.0. showing what the original behavior is and what the new is. |
|
can you update according to comments |
hensing
force-pushed
the
panel_to_frame_fix
branch
from
cee665d to
7edbb3b
Compare
|
@jreback: updated the commit according to your comments! |
|
hensing
force-pushed
the
panel_to_frame_fix
branch
2 times, most recently
from
05bf61e to
5f9e49a
Compare
hensing
force-pushed
the
panel_to_frame_fix
branch
from
5f9e49a to
533cec7
Compare
|
added/fixed tests and added sub-section |
| @@ -63,6 +63,7 @@ Highlights include: | |||
| - Development support for benchmarking with the `Air Speed Velocity library <https://github.com/spacetelescope/asv/>`_ (:issue:`8316`) | |||
| - Support for reading SAS xport files, see :ref:`here <whatsnew_0170.enhancements.sas_xport>` | |||
| - Removal of the automatic TimeSeries broadcasting, deprecated since 0.8.0, see :ref:`here <whatsnew_0170.prior_deprecations>` | |||
| - Deprecated ``filter_observations`` by ``dropna`` in ``Panel.to_frame`` and changed default to ``True`` (:issue:`7879`) | |||
There was a problem hiding this comment.
move this to the whatsnew/v0.17.0 in the deprecation section. This needs an example in a sub-section. Showing the previous usage and the new.
|
this is pushed to 0.18.0 pls update when you can |
|
closing, but if you'd like to update, pls reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7879 by changing API (filter_observations=True now deprecated and replaced with dropna=False)