BUG: encoding of categoricals in hdf serialization #10889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cottrell I changed this a bit to explicity check for bytes, and doced this a bit. Seems ok to me, but can you check for |
| @@ -765,3 +765,4 @@ Bug Fixes | |||
| - Bug in ``read_msgpack`` where encoding is not respected (:issue:`10580`) | |||
| - Bug preventing access to the first index when using ``iloc`` with a list containing the appropriate negative integer (:issue:`10547`, :issue:`10779`) | |||
| - Bug in ``TimedeltaIndex`` formatter causing error while trying to save ``DataFrame`` with ``TimedeltaIndex`` using ``to_csv`` (:issue:`10833`) | |||
| - Bug in ``Categorical`` hdf serialiation in presence of alternate encodings. (:issue:`10366`) | |||
jreback
force-pushed
the
cottrell-categ_hdf
branch
from
ea50146 to
c589faf
Compare
|
nosetests -v pandas.io.tests.test_pytables passed on my local python 3.4.3 build. I see other errors popping up as in the travis tests. |
jreback
force-pushed
the
cottrell-categ_hdf
branch
from
c589faf to
8609f6c
Compare
jreback
added a commit
that referenced
this pull request
Aug 28, 2015
BUG: encoding of categoricals in hdf serialization
|
thanks @cottrell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10366
replaces #10454