ERR: better error reporting for failing parsing in timedelta/timeseries #10720

[springcoil]

closes #10720

[jorisvandenbossche]

Why did you close this one?

[jorisvandenbossche]

Some advice:

• always work on a branch and not in master for a PR (so this one is better than BUG: 10720 - Test error message enhancement #10884, I can reopen this one if you want)

• always update with the latest upstream before starting a new branch (you have still some old commits of a previous pr):

  git checkout master
  git fetch upstream
  git merge upstream/master --ff-only
  git checkout -b new_branch
  

  or now if you already started a branch, rebase it on master:

  git fetch upstream
  git rebase upstream/master
  

[springcoil]

Ohh i closed the other one because i wanted to rebase. Thanks for the tip

On Saturday, 22 August 2015, Joris Van den Bossche [email protected]
wrote:

Some advice:

• always work on a branch and not in master for a PR (so this one is
  better than BUG: 10720 - Test error message enhancement #10884 BUG: 10720 - Test error message enhancement #10884, I
  can reopen this one if you want)
• always update with the latest upstream before starting a new branch
  (you have still some old commits of a previous pr): git checkout
  master git fetch upstream git merge upstream/master --ff-only git checkout
  -b new_branch

—
Reply to this email directly or view it on GitHub
#10883 (comment).

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

[springcoil]

Can you reopen this one instead and close the other one?

[springcoil]

Ok - so that attempt passed, any got any feedback about whether it's ready to be merged or does it need some more work?

[jreback]

his is not doing anything

use assertRaisesRegExp

[springcoil]

Seems ready

[jreback]

@springcoil this doesn't do anything. as you didn't actually change any code except for the tests. So this fails. And it still is not rebased on master.

In [1]: td = pd.Series(['May 04', 'Jun 02', ''], index=[1,2,3])

In [3]: pd.to_datetime(td,format='%b %y', errors='raise') 
ValueError: time data '' does not match format '%b %y' (match)

[springcoil]

Ok will fix that

On Saturday, 22 August 2015, Jeff Reback [email protected] wrote:

@springcoil https://github.com/springcoil this doesn't do anything. as
you didn't actually change any code except for the tests. So this fails.
And it still is not rebased on master.

In [1]: td = pd.Series(['May 04', 'Jun 02', ''], index=[1,2,3])

In [3]: pd.to_datetime(td,format='%b %y', errors='raise')
ValueError: time data '' does not match format '%b %y' (match)

—
Reply to this email directly or view it on GitHub
#10883 (comment).

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

[springcoil]

I'm going to close this for now.